Add a note about counting leaves in a tree.#3200
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3200 +/- ##
=======================================
Coverage 89.63% 89.63%
=======================================
Files 28 28
Lines 31978 31978
Branches 5872 5872
=======================================
Hits 28662 28662
Misses 1886 1886
Partials 1430 1430
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jeromekelleher
approved these changes
Jun 8, 2025
| Tree.num_tracked_samples | ||
|
|
||
| Note that :meth:Tree.num_samples provides an efficient way to count samples under a node | ||
| (when sample_lists=True is specified during tree creation). However, samples and leaves |
Member
There was a problem hiding this comment.
Delete this comment - counting samples is always efficient, sample_lists is something else
Member
Author
There was a problem hiding this comment.
Oh yes, I misunderstood, sorry. Now corrected, and I added another tiny typo correction into the concatenate docs
hyanwong
force-pushed
the
leaf-count-clarification
branch
4 times, most recently
from
b51ba8c to
809ef48
Compare
hyanwong
force-pushed
the
leaf-count-clarification
branch
from
809ef48 to
8017b46
Compare
jeromekelleher
approved these changes
Jun 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is important to state, for the people coming from phylogenetic fields who are looking for a Tree.num_leaves()` method.